Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instance Poller - Remove Provider IDs for Unobserved Link-Layer Devices #11778

Merged
merged 2 commits into from Jun 30, 2020

Conversation

manadart
Copy link
Member

@manadart manadart commented Jun 30, 2020

Description of change

This patch ensures that when the instance-poller relinquishes responsibility for a link-layer device in state, it removes any provider ID from the device and from the global collection.

QA steps

  • Bootstrap to AWS.
  • Connect to Mongo, copy one of the devices documents and insert it changing the _id, name, providerid and mac-address something like:
db.linklayerdevices.insertOne({
        "_id" : "bdf5cc58-afb7-4ff8-8a8c-d7487e02970a:m#0#d#ens6",
        "name" : "ens6",
        "model-uuid" : "bdf5cc58-afb7-4ff8-8a8c-d7487e02970a",
        "mtu" : 9001,
        "machine-id" : "0",
        "type" : "ethernet",
        "mac-address" : "0a:99:77:5a:ed:c6",
        "is-auto-start" : true,
        "is-up" : true,
        "parent-name" : "",
        "providerid" : "p-oneZ[O]R!"
})
  • You can wait for the instance-poller to run, or SSH to the controller machine and execute sudo systemctl restart jujud-machine-0.
  • After a while this document should have providerid unset.

Documentation changes

None.

Bug reference

N/A

link-layer device.

Unsetting such an ID also removes it from the global ID collection.
link-layer device, that it unsets the provider ID.
@manadart manadart added the 2.8 label Jun 30, 2020
@manadart
Copy link
Member Author

Copy link
Contributor

@achilleasa achilleasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@manadart
Copy link
Member Author

$$merge$$

@manadart
Copy link
Member Author

Status tests again.
$$merge$$

@manadart
Copy link
Member Author

And again.
$$merge$$

@jujubot jujubot merged commit b0ade1a into juju:2.8 Jun 30, 2020
@manadart manadart deleted the 2.8-instance-poller-dev-provider-id branch July 1, 2020 07:28
@manadart manadart mentioned this pull request Jul 2, 2020
jujubot added a commit that referenced this pull request Jul 2, 2020
#11795

Merge from 2.8 to bring forward:
- #11794 from manadart/2.8-address-conversion-rework
- #11789 from SimonRichardson/actions-list-output
- #11693 from tlm/model-admission-upgrade
- #11785 from manadart/2.8-machiner-lld-prep
- #11790 from achilleasa/2.8-filter-non-live-relations-from-relation-ids-output
- #11792 from wallyworld/add-centos8
- #11791 from howbazaar/2.8-fix-intermittent-status-tests
- #11787 from hmlanigan/add-k8s-error-output
- #11780 from SimonRichardson/api-schema-admin
- #11773 from tlm/json-num
- #11783 from wallyworld/merge-2.7-20200701
- #11776 from ycliuhw/lp-1882149
- #11778 from manadart/2.8-instance-poller-dev-provider-id
- #11765 from achilleasa/2.8-enable-relation-list-to-show-remote-application
- #11768 from ycliuhw/fix/CAAS-CI-LB-GET
- #11770 from hmlanigan/unicode-vs-str
- #11769 from hmlanigan/unicode-vs-str
- #11766 from hmlanigan/autoload-cred-lxd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants