Create pull secrets for sidecar containers. #13140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpidcock
force-pushed
the
pull-secrets
branch
3 times, most recently
from
292d33a
to
4cffa5d
Compare
|
|
1 similar comment
|
|
Merged
jujubot
added a commit
that referenced
this pull request
Jul 8, 2021
#13143 ### Merge 2.9 into develop 6ad00ba (upstream/2.9, origin/2.9, 2.9) Merge pull request #13142 from SimonRichardson/2.8-into-2.9-cache f4b4ab4 Merge pull request #13140 from hpidcock/pull-secrets 185fac6 Merge pull request #13135 from wallyworld/cass-image-repo-port 2b67b0a Merge pull request #13134 from achilleasa/2.9-backport-equinix-provider-support 43b8197 (achilleasa/2.9) Merge pull request #13129 from ycliuhw/fix/lp-1934180 25e8028 Merge pull request #13128 from tlm/oauth-cred-k8s-lp1929910 7b18431 Merge pull request #13133 from SimonRichardson/pod-ready-timeout c139c11 Merge pull request #13130 from SimonRichardson/set-config-empty-string ### Conflicts: CONFLICT (content): Merge conflict in cmd/juju/commands/bootstrap_test.go CONFLICT (content): Merge conflict in cloudconfig/podcfg/podcfg_test.go CONFLICT (content): Merge conflict in cloudconfig/podcfg/image.go CONFLICT (content): Merge conflict in cloud/clouds_test.go CONFLICT (content): Merge conflict in apiserver/facades/client/application/application_unit_test.go CONFLICT (content): Merge conflict in apiserver/facades/agent/uniter/uniter.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds image pull secrets for sidecar charms with private images such as from charmhub.
QA steps
Deploy charm with private repo images.
Check image pull secrets exist and images pull.
Refresh charm with public repo images.
Check image pull secrets are cleaned up.
Documentation changes
N/A
Bug reference
https://bugs.launchpad.net/juju/+bug/1934416