Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inbuilt dashboard since we are moving to use a separate charm #13370

Merged
merged 1 commit into from Sep 29, 2021

Conversation

wallyworld
Copy link
Member

We are moving to deploy the juju dashboard using a charm instead of it being served by the controller.
This means that the workflow and CLI around locating and pulling a dashboard tarball from simplestreams and uploading it to the controller and extracting it and providing http endpoints on the controller API etc are all no longer needed.

Also tweak the controller-url config for the controller charm to include the port.

QA steps

juju bootstrap --no-default-model
(see that no dashboard messages are logged)

juju config controller
...
charm: juju-controller
settings:
  controller-url:
    default: ""
    description: The URL used to access the controller API.
    source: user
    type: string
    value: wss://10.24.226.7:17070/api
...

Bug reference

https://bugs.launchpad.net/juju/+bug/1945363

@wallyworld
Copy link
Member Author

Copy link
Member

@ycliuhw ycliuhw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question

cmd/juju/dashboard/dashboard.go Show resolved Hide resolved
@wallyworld
Copy link
Member Author

$$merge$$

1 similar comment
@wallyworld
Copy link
Member Author

$$merge$$

@jujubot jujubot merged commit 3401423 into juju:develop Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants