/juju

provider: remove unused constants #1531

Merged
merged 2 commits into from Feb 3, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@davecheney @jujubot
@davecheney
Contributor

davecheney commented Feb 3, 2015

By its own admision this file should not exist. This PR is a first step towards its removal.

Importantly the purpose of this file is not to enumerate all the known providers. This is for two reasons

  1. If a set of provider names is required, it should be recovered from registered providers
  2. The set of registered providers depends if they are registered or not, so making this list a set of all known providers is pointless if they are not registered.

(Review request: http://reviews.vapour.ws/r/856/)
@davecheney
provider: remove unused constants 
By its own admision this file should not exist. This PR is a first step towards its removal.

Importantly the purpose of this file is _not_ to enumerate all the known providers. This is for two reasons

1. If a set of provider names is required, it should be recovered from registered providers
2. The set of registered providers depends if they are registered or not, so making this list a set of all known providers is pointless if they are not registered.
6e894ee
@davecheney
Contributor

davecheney commented Feb 3, 2015

$$merge$$
@jujubot
Contributor

jujubot commented Feb 3, 2015

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju
@jujubot
Contributor

jujubot commented Feb 3, 2015

Build failed: Generating tarball failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/2014
@davecheney
Contributor

davecheney commented Feb 3, 2015

$$merge$$
@jujubot
Contributor

jujubot commented Feb 3, 2015

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju
@jujubot
Contributor

jujubot commented Feb 3, 2015

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/2015
@davecheney
Contributor

davecheney commented Feb 3, 2015

$$merge$$
@jujubot
Contributor

jujubot commented Feb 3, 2015

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

jujubot added a commit that referenced this pull request Feb 3, 2015

@jujubot
Merge pull request #1531 from davecheney/221-provider-remove-unused-c… 
…onstants

provider: remove unused constants

By its own admision this file should not exist. This PR is a first step towards its removal.

Importantly the purpose of this file is _not_ to enumerate all the known providers. This is for two reasons

1. If a set of provider names is required, it should be recovered from registered providers
2. The set of registered providers depends if they are registered or not, so making this list a set of all known providers is pointless if they are not registered.

(Review request: http://reviews.vapour.ws/r/856/)
6508c7f

@jujubot jujubot merged commit 6508c7f into juju:master Feb 3, 2015

@davecheney davecheney deleted the davecheney:221-provider-remove-unused-constants branch Apr 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment