/juju

Have juju-backup respond like a proper plugin #1596

Merged
merged 2 commits into from Feb 22, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@marcoceppi @jujubot
@marcoceppi
Owner

marcoceppi commented Feb 12, 2015

This fixes LP:1389326

(Review request: http://reviews.vapour.ws/r/926/)
@marcoceppi
Owner

marcoceppi commented Feb 18, 2015

:shakeitlikeapolaroidpictureee:
@marcoceppi
Owner

marcoceppi commented Feb 18, 2015

Apparently the format for this has changed
@marcoceppi
Owner

marcoceppi commented Feb 18, 2015

$$fixes-1389326$$
@jujubot
Contributor

jujubot commented Feb 18, 2015

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju
@jujubot
Contributor

jujubot commented Feb 18, 2015

Build failed: Does not match ['fixes-1421237']
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/2178
@marcoceppi
Owner

marcoceppi commented Feb 20, 2015

$$fixes-1389326$$
@jujubot
Contributor

jujubot commented Feb 20, 2015

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju
@jujubot
Contributor

jujubot commented Feb 20, 2015

Build failed: Does not match ['fixes-1423782']
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/2209
@marcoceppi
Owner

marcoceppi commented Feb 22, 2015

$$fixes-1389326$$
@jujubot
Contributor

jujubot commented Feb 22, 2015

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

jujubot added a commit that referenced this pull request Feb 22, 2015

@jujubot
Merge pull request #1596 from marcoceppi/lp-1389326 
Have juju-backup respond like a proper plugin

This fixes [LP:1389326](https://bugs.launchpad.net/juju-core/+bug/1389326)

(Review request: http://reviews.vapour.ws/r/926/)
c59665e

@jujubot jujubot merged commit c59665e into juju:master Feb 22, 2015

@dimitern dimitern referenced this pull request Feb 26, 2015

Merged

Fixed lp:1425807 - functional-ha-backup CI job failure due to backup/restore changes #1693

jujubot added a commit that referenced this pull request Feb 26, 2015

@jujubot
Merge pull request #1693 from dimitern/lp-1425807-fix-restore-ci 
Fixed lp:1425807 - functional-ha-backup CI job failure due to backup/restore changes

The culprit most likely is the combination of #1667 (redirecting juju
restore to juju backups restore) and mostly #1596 - causing an early
"exit 1" due to missing quotes around a bash if block, thus confusing
the CI job to think restore (expectedly) failed earlier.

(Review request: http://reviews.vapour.ws/r/1021/)
0872c2c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment