Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Fix go vet warnings with go1.4.1 version of go vet #1654
Conversation
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Does not match ['fixes-1424669'] |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Thanks for fixing these. The provisioner.go warnings are actually reported by go vet under 1.2. That's why I came looking at the PR queue to see if anyone had already fixed them :) |
added a commit
that referenced
this pull request
Feb 26, 2015
jujubot
merged commit 31ca67f
into
juju:master
Feb 26, 2015
johnweldon
deleted the
johnweldon:go-vet-warnings
branch
Feb 26, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
johnweldon commentedFeb 23, 2015
Go version 1.4 uses an updated version of
go vetthat finds warnings that Go version 1.2.1 doesn't find.This PR cleans up a couple logging calls that the newer
go vetfinds troublesome.Fixes output of go vet with go1.4.1 : http://paste.ubuntu.com/10372604/
(Review request: http://reviews.vapour.ws/r/981/)