Fix go vet warnings with go1.4.1 version of go vet #1654

Merged
merged 1 commit into from Feb 26, 2015

Conversation

Projects
None yet
4 participants
Contributor

johnweldon commented Feb 23, 2015

Go version 1.4 uses an updated version of go vet that finds warnings that Go version 1.2.1 doesn't find.

This PR cleans up a couple logging calls that the newer go vet finds troublesome.

Fixes output of go vet with go1.4.1 : http://paste.ubuntu.com/10372604/

    go version go1.4.1
    checking: go fmt ...
    checking: go vet ...
    apiserver/provisioner/provisioner.go:1028: arg addr for printf verb %q of wrong type: *github.com/juju/juju/state.IPAddress
    apiserver/provisioner/provisioner.go:1032: arg addr for printf verb %q of wrong type: *github.com/juju/juju/state.IPAddress
    apiserver/provisioner/provisioner.go:1040: arg addr for printf verb %q of wrong type: *github.com/juju/juju/state.IPAddress
    apiserver/provisioner/provisioner.go:1046: arg addr for printf verb %q of wrong type: *github.com/juju/juju/state.IPAddress
    apiserver/provisioner/provisioner.go:1052: arg addr for printf verb %q of wrong type: *github.com/juju/juju/state.IPAddress
    apiserver/provisioner/provisioner.go:1080: arg addr for printf verb %q of wrong type: *github.com/juju/juju/state.IPAddress
    apiserver/provisioner/provisioner.go:1088: arg addr for printf verb %q of wrong type: *github.com/juju/juju/state.IPAddress
    apiserver/provisioner/provisioner.go:1095: arg addr for printf verb %q of wrong type: *github.com/juju/juju/state.IPAddress
    apiserver/provisioner/provisioner.go:1098: arg addr for printf verb %q of wrong type: *github.com/juju/juju/state.IPAddress
    apiserver/provisioner/provisioner.go:1113: arg addr for printf verb %q of wrong type: *github.com/juju/juju/state.IPAddress
    apiserver/provisioner/prepare_test.go:316: arg ip for printf verb %q of wrong type: *github.com/juju/juju/state.IPAddress
    apiserver/provisioner/prepare_test.go:382: arg ip for printf verb %q of wrong type: *github.com/juju/juju/state.IPAddress
    apiserver/provisioner/prepare_test.go:395: arg ip for printf verb %q of wrong type: *github.com/juju/juju/state.IPAddress
    apiserver/provisioner/prepare_test.go:401: arg ip for printf verb %q of wrong type: *github.com/juju/juju/state.IPAddress
    apiserver/provisioner/prepare_test.go:465: arg ip for printf verb %q of wrong type: *github.com/juju/juju/state.IPAddress
    apiserver/provisioner/prepare_test.go:471: arg ip for printf verb %q of wrong type: *github.com/juju/juju/state.IPAddress
    juju/testing/conn.go:276: possible formatting directive in Log call

(Review request: http://reviews.vapour.ws/r/981/)

Fix go vet warnings with go1.4.1 version of go vet
    go version go1.4.1
    checking: go fmt ...
    checking: go vet ...
    apiserver/provisioner/provisioner.go:1028: arg addr for printf verb %q of wrong type: *github.com/juju/juju/state.IPAddress
    apiserver/provisioner/provisioner.go:1032: arg addr for printf verb %q of wrong type: *github.com/juju/juju/state.IPAddress
    apiserver/provisioner/provisioner.go:1040: arg addr for printf verb %q of wrong type: *github.com/juju/juju/state.IPAddress
    apiserver/provisioner/provisioner.go:1046: arg addr for printf verb %q of wrong type: *github.com/juju/juju/state.IPAddress
    apiserver/provisioner/provisioner.go:1052: arg addr for printf verb %q of wrong type: *github.com/juju/juju/state.IPAddress
    apiserver/provisioner/provisioner.go:1080: arg addr for printf verb %q of wrong type: *github.com/juju/juju/state.IPAddress
    apiserver/provisioner/provisioner.go:1088: arg addr for printf verb %q of wrong type: *github.com/juju/juju/state.IPAddress
    apiserver/provisioner/provisioner.go:1095: arg addr for printf verb %q of wrong type: *github.com/juju/juju/state.IPAddress
    apiserver/provisioner/provisioner.go:1098: arg addr for printf verb %q of wrong type: *github.com/juju/juju/state.IPAddress
    apiserver/provisioner/provisioner.go:1113: arg addr for printf verb %q of wrong type: *github.com/juju/juju/state.IPAddress
    apiserver/provisioner/prepare_test.go:316: arg ip for printf verb %q of wrong type: *github.com/juju/juju/state.IPAddress
    apiserver/provisioner/prepare_test.go:382: arg ip for printf verb %q of wrong type: *github.com/juju/juju/state.IPAddress
    apiserver/provisioner/prepare_test.go:395: arg ip for printf verb %q of wrong type: *github.com/juju/juju/state.IPAddress
    apiserver/provisioner/prepare_test.go:401: arg ip for printf verb %q of wrong type: *github.com/juju/juju/state.IPAddress
    apiserver/provisioner/prepare_test.go:465: arg ip for printf verb %q of wrong type: *github.com/juju/juju/state.IPAddress
    apiserver/provisioner/prepare_test.go:471: arg ip for printf verb %q of wrong type: *github.com/juju/juju/state.IPAddress
    juju/testing/conn.go:276: possible formatting directive in Log call
Contributor

johnweldon commented Feb 23, 2015

$$merge$$

Contributor

jujubot commented Feb 23, 2015

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

jujubot commented Feb 23, 2015

Build failed: Does not match ['fixes-1424669']
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/2239

Contributor

dimitern commented Feb 25, 2015

$$merge$$

Contributor

jujubot commented Feb 25, 2015

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

mjs commented Feb 26, 2015

Thanks for fixing these. The provisioner.go warnings are actually reported by go vet under 1.2. That's why I came looking at the PR queue to see if anyone had already fixed them :)

jujubot added a commit that referenced this pull request Feb 26, 2015

Merge pull request #1654 from johnweldon/go-vet-warnings
Fix go vet warnings with go1.4.1 version of go vet

Go version 1.4 uses an updated version of `go vet` that finds warnings that Go version 1.2.1 doesn't find.

This PR cleans up a couple logging calls that the newer `go vet` finds troublesome.


Fixes output of go vet with go1.4.1 : http://paste.ubuntu.com/10372604/

```
    go version go1.4.1
    checking: go fmt ...
    checking: go vet ...
    apiserver/provisioner/provisioner.go:1028: arg addr for printf verb %q of wrong type: *github.com/juju/juju/state.IPAddress
    apiserver/provisioner/provisioner.go:1032: arg addr for printf verb %q of wrong type: *github.com/juju/juju/state.IPAddress
    apiserver/provisioner/provisioner.go:1040: arg addr for printf verb %q of wrong type: *github.com/juju/juju/state.IPAddress
    apiserver/provisioner/provisioner.go:1046: arg addr for printf verb %q of wrong type: *github.com/juju/juju/state.IPAddress
    apiserver/provisioner/provisioner.go:1052: arg addr for printf verb %q of wrong type: *github.com/juju/juju/state.IPAddress
    apiserver/provisioner/provisioner.go:1080: arg addr for printf verb %q of wrong type: *github.com/juju/juju/state.IPAddress
    apiserver/provisioner/provisioner.go:1088: arg addr for printf verb %q of wrong type: *github.com/juju/juju/state.IPAddress
    apiserver/provisioner/provisioner.go:1095: arg addr for printf verb %q of wrong type: *github.com/juju/juju/state.IPAddress
    apiserver/provisioner/provisioner.go:1098: arg addr for printf verb %q of wrong type: *github.com/juju/juju/state.IPAddress
    apiserver/provisioner/provisioner.go:1113: arg addr for printf verb %q of wrong type: *github.com/juju/juju/state.IPAddress
    apiserver/provisioner/prepare_test.go:316: arg ip for printf verb %q of wrong type: *github.com/juju/juju/state.IPAddress
    apiserver/provisioner/prepare_test.go:382: arg ip for printf verb %q of wrong type: *github.com/juju/juju/state.IPAddress
    apiserver/provisioner/prepare_test.go:395: arg ip for printf verb %q of wrong type: *github.com/juju/juju/state.IPAddress
    apiserver/provisioner/prepare_test.go:401: arg ip for printf verb %q of wrong type: *github.com/juju/juju/state.IPAddress
    apiserver/provisioner/prepare_test.go:465: arg ip for printf verb %q of wrong type: *github.com/juju/juju/state.IPAddress
    apiserver/provisioner/prepare_test.go:471: arg ip for printf verb %q of wrong type: *github.com/juju/juju/state.IPAddress
    juju/testing/conn.go:276: possible formatting directive in Log call
```

(Review request: http://reviews.vapour.ws/r/981/)

@jujubot jujubot merged commit 31ca67f into juju:master Feb 26, 2015

@johnweldon johnweldon deleted the johnweldon:go-vet-warnings branch Feb 26, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment