Deprecate old restore plugin #1667

Merged
merged 1 commit into from Feb 26, 2015

Conversation

Projects
None yet
2 participants
Contributor

perrito666 commented Feb 24, 2015

Since the merge of the new restore method, the old restore plugin is of no use and will not be maintained.
This change makes the plugin just make an equivalent call to "juju backups restore" and inform the user of it.
There is also a small fix of a typo I introduced in the last fix of restore and some improved error reporting to better suit this change.

(Review request: http://reviews.vapour.ws/r/995/)

Contributor

perrito666 commented Feb 24, 2015

$$merge$$

Contributor

jujubot commented Feb 24, 2015

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

jujubot commented Feb 24, 2015

Build failed: Does not match ['fixes-1424695', 'fixes-1424777', 'fixes-1424669']
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/2247

Contributor

perrito666 commented Feb 24, 2015

$$merge$$

Contributor

jujubot commented Feb 24, 2015

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

jujubot commented Feb 24, 2015

Build failed: Does not match ['fixes-1424777']
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/2256

Contributor

perrito666 commented Feb 25, 2015

$$merge$$

On Tuesday, February 24, 2015, Juju bot notifications@github.com wrote:

Build failed: Does not match ['fixes-1424777']
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/2256


Reply to this email directly or view it on GitHub
#1667 (comment).

Contributor

jujubot commented Feb 25, 2015

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

jujubot commented Feb 25, 2015

Build failed: Does not match ['fixes-1424777']
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/2265

Contributor

perrito666 commented Feb 25, 2015

$$merge$$

On Wed, Feb 25, 2015 at 6:36 AM, Juju bot notifications@github.com wrote:

Build failed: Does not match ['fixes-1424777']
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/2265


Reply to this email directly or view it on GitHub
#1667 (comment).

Contributor

jujubot commented Feb 25, 2015

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

jujubot commented Feb 25, 2015

Build failed: Does not match ['fixes-1424777']
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/2266

Contributor

perrito666 commented Feb 25, 2015

$$merge$$

On Wednesday, February 25, 2015, Juju bot notifications@github.com wrote:

Build failed: Does not match ['fixes-1424777']
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/2265


Reply to this email directly or view it on GitHub
#1667 (comment).

Contributor

jujubot commented Feb 25, 2015

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

jujubot commented Feb 25, 2015

Build failed: Does not match ['fixes-1424777']
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/2269

Contributor

perrito666 commented Feb 25, 2015

$$merge$$

On Wednesday, February 25, 2015, Juju bot notifications@github.com wrote:

Build failed: Does not match ['fixes-1424777']
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/2269


Reply to this email directly or view it on GitHub
#1667 (comment).

Contributor

jujubot commented Feb 25, 2015

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

jujubot commented Feb 25, 2015

Build failed: Does not match ['fixes-1424777']
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/2270

Contributor

perrito666 commented Feb 25, 2015

$$merge$$

On Wednesday, February 25, 2015, Juju bot notifications@github.com wrote:

Build failed: Does not match ['fixes-1424777']
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/2270


Reply to this email directly or view it on GitHub
#1667 (comment).

Contributor

jujubot commented Feb 25, 2015

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

jujubot commented Feb 25, 2015

Build failed: Does not match ['fixes-1424777']
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/2273

Contributor

perrito666 commented Feb 25, 2015

$$merge$$

On Wed, Feb 25, 2015 at 2:00 PM, Juju bot notifications@github.com wrote:

Build failed: Does not match ['fixes-1424777']
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/2273


Reply to this email directly or view it on GitHub
#1667 (comment).

Contributor

jujubot commented Feb 25, 2015

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

jujubot commented Feb 25, 2015

Build failed: Does not match ['fixes-1424777']
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/2274

Contributor

perrito666 commented Feb 25, 2015

$$merge$$

Contributor

jujubot commented Feb 25, 2015

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

jujubot added a commit that referenced this pull request Feb 26, 2015

Merge pull request #1667 from perrito666/deprecate_restore_plugin
Deprecate old restore plugin

Since the merge of the new restore method, the old restore plugin is of no use and will not be maintained.
This change makes the plugin just make an equivalent call to "juju backups restore" and inform the user of it.
There is also a small fix of a typo I introduced in the last fix of restore and some improved error reporting to better suit this change.

(Review request: http://reviews.vapour.ws/r/995/)

@jujubot jujubot merged commit 80daee2 into juju:master Feb 26, 2015

jujubot added a commit that referenced this pull request Feb 26, 2015

Merge pull request #1693 from dimitern/lp-1425807-fix-restore-ci
Fixed lp:1425807 - functional-ha-backup CI job failure due to backup/restore changes

The culprit most likely is the combination of #1667 (redirecting juju
restore to juju backups restore) and mostly #1596 - causing an early
"exit 1" due to missing quotes around a bash if block, thus confusing
the CI job to think restore (expectedly) failed earlier.

(Review request: http://reviews.vapour.ws/r/1021/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment