Introduce 'juju environment create' #1731

Merged
merged 2 commits into from Mar 4, 2015

Conversation

Projects
None yet
3 participants
Owner

howbazaar commented Mar 4, 2015

This is protected by the 'jes' feature flag.

cmd/juju/environment/create.go
+}
+
+const createEnvHelpDoc = `
+If configuration values are passed by both extra command line arguments and
@mjs

mjs Mar 4, 2015

Contributor

This paragraph should go second.

cmd/juju/environment/create.go
+
+ // Create the configstore entry and write it to disk, as this will error
+ // if one with the same name already exists IF we are creating an
+ // environment for ourselves.
@mjs

mjs Mar 4, 2015

Contributor

I dont' quite understand this comment. The config is being written to disk because it will error if one with same name already exists?

Contributor

mjs commented Mar 4, 2015

LGTM. Just some minor docstring issues.

Owner

howbazaar commented Mar 4, 2015

$$JFDI$$

Contributor

jujubot commented Mar 4, 2015

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

jujubot added a commit that referenced this pull request Mar 4, 2015

Merge pull request #1731 from howbazaar/juju-environment-create
Introduce 'juju environment create'

This is protected by the 'jes' feature flag.

@jujubot jujubot merged commit 1e3a2d6 into juju:master Mar 4, 2015

@howbazaar howbazaar deleted the howbazaar:juju-environment-create branch Jan 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment