/juju

service: predictable ListServicesCommand output #1738

Merged
merged 2 commits into from Mar 4, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@axw @jujubot
@axw
Member

axw commented Mar 4, 2015

ListServicesCommand iterates over a map to generate a command. We were
previously relying on service listing commands being predictable, and this
new behaviour is not, since iterating over a map is pseudo-random. We
change the function to iterate over the sorted map keys instead.

Also:
cmd/juju/environment: add missing formatting

(Review request: http://reviews.vapour.ws/r/1068/)

axw added some commits Mar 4, 2015

@axw
service: predictable ListServicesCommand output 
ListServicesCommand iterates over a map to generate
a command. We were previously relying on service
listing commands being predictable, and this new
behaviour is not, since iterating over a map is
pseudo-random. We change the function to iterate
over the sorted map keys instead.
57af5eb
@axw
cmd/juju/environment: add missing formatting
b2400f2
@axw
Member

axw commented Mar 4, 2015

$$merge$$
@jujubot
Contributor

jujubot commented Mar 4, 2015

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

jujubot added a commit that referenced this pull request Mar 4, 2015

@jujubot
Merge pull request #1738 from axw/service-sort-command 
service: predictable ListServicesCommand output

ListServicesCommand iterates over a map to generate a command. We were
previously relying on service listing commands being predictable, and this
new behaviour is not, since iterating over a map is pseudo-random. We
change the function to iterate over the sorted map keys instead.

Also:
    cmd/juju/environment: add missing formatting

(Review request: http://reviews.vapour.ws/r/1068/)
8ec1c65

@jujubot jujubot merged commit 8ec1c65 into juju:master Mar 4, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment