/juju

Only log rpc request params and response body at trace level #1782

Merged
merged 1 commit into from Mar 10, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@wallyworld @axw @jujubot
@wallyworld
Owner

wallyworld commented Mar 10, 2015

We can't easily remove credentials for rpc request params and responses. By default, logging is initially at debug level which causes credential to leak. So we change the rpc logging to still log the rpc metadata at debug level, bt also add in trace level debugging of the unredacted data.

Fixes: https://bugs.launchpad.net/juju-core/+bug/1423272
@axw
Member

axw commented Mar 10, 2015

LGTM
@wallyworld
Owner

wallyworld commented Mar 10, 2015

$$JFDI$$
@jujubot
Contributor

jujubot commented Mar 10, 2015

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

jujubot added a commit that referenced this pull request Mar 10, 2015

@jujubot
Merge pull request #1782 from wallyworld/quieter-apiserver-logs 
Only log rpc request params and response body at trace level

We can't easily remove credentials for rpc request params and responses. By default, logging is initially at debug level which causes credential to leak. So we change the rpc logging to still log the rpc metadata at debug level, bt also add in trace level debugging of the unredacted data.

Fixes: https://bugs.launchpad.net/juju-core/+bug/1423272
85c2a32

@jujubot jujubot merged commit 85c2a32 into juju:master Mar 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment