state: use errors.Cause in IsNotAssigned #1789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a change in PR 1707 that causes the megawatcher to fail if the unit is not yet assigned to a machine. The cause is that a call to errors.Cause was removed in back-porting a fix from master, but IsNotAssigned does not do this in 1.22 as it does on master. This branch changes IsNotAssigned to call errors.Cause. Fixes https://bugs.launchpad.net/juju-core/+bug/1430049
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
added a commit
that referenced
this pull request
Mar 10, 2015
state: use errors.Cause in IsNotAssigned There was a change in PR 1707 that causes the megawatcher to fail if the unit is not yet assigned to a machine. The cause is that a call to errors.Cause was removed in back-porting a fix from master, but IsNotAssigned does not do this in 1.22 as it does on master. This branch changes IsNotAssigned to call errors.Cause. Fixes https://bugs.launchpad.net/juju-core/+bug/1430049 (Review request: http://reviews.vapour.ws/r/1117/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a change in PR 1707 that causes the
megawatcher to fail if the unit is not yet assigned to
a machine. The cause is that a call to errors.Cause was
removed in back-porting a fix from master, but
IsNotAssigned does not do this in 1.22 as it does on
master.
This branch changes IsNotAssigned to call errors.Cause.
Fixes https://bugs.launchpad.net/juju-core/+bug/1430049
(Review request: http://reviews.vapour.ws/r/1117/)