/juju

Various tests fixes for windows #1791

Closed
wants to merge 5 commits into
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@gabriel-samfira
@gabriel-samfira
Member

gabriel-samfira commented Mar 10, 2015

This branch makes tests pass on windows again. Fixes include changing some tests to use proper path detection based on series/os and one change that will get replaced as soon as I get a chance to propose the refactor of the windows service module.

I am aware that its ugly at the moment, but I do have a proper module in the works, that will replace this sad implementation I made (tests included).

(Review request: http://reviews.vapour.ws/r/1119/)

gabriel-samfira added some commits Mar 10, 2015

@gabriel-samfira
Various tests fixes for windows
fc90693
@gabriel-samfira
added TODO
65126ff
@gabriel-samfira
Added newline before build constraint
3f4f304
@gabriel-samfira
fix some file cleanup in tests 
On windows You need to explicitly close a file before removing. Without
this change I end up with about 1600 files
b2e328e
@gabriel-samfira
local provider not supported on windows
8b4d559

@gabriel-samfira gabriel-samfira closed this Apr 16, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment