/juju

New watcher for machine storage attachments #1841

Merged
merged 16 commits into from Mar 16, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@axw @jujubot @dimitern
@axw
Member

axw commented Mar 16, 2015

This change adds the following things:

  • a new watcher (facade, type) for watching volume attachments. There will be another facade added for watching filesystem attachments later, but otherwise the code will be shared.
  • updates to the storageprovisioner API for watching volume attachments
  • params.VolumeAttachmentId(s) replaced with params.MachineStorageId(s) -- will be reused for filesystems

(Review request: http://reviews.vapour.ws/r/1168/)
@axw
Member

axw commented Mar 16, 2015

$$merge$$
@jujubot
Contributor

jujubot commented Mar 16, 2015

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju
@jujubot
Contributor

jujubot commented Mar 16, 2015

Build failed: Does not match ['fixes-1431888']
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/2493
@dimitern
Contributor

dimitern commented Mar 16, 2015

$$retry$$
@jujubot
Contributor

jujubot commented Mar 16, 2015

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

jujubot added a commit that referenced this pull request Mar 16, 2015

@jujubot
Merge pull request #1841 from axw/watch-machine-storage 
New watcher for machine storage attachments

This change adds the following things:
 - a new watcher (facade, type) for watching volume attachments. There will be another facade added for watching filesystem attachments later, but otherwise the code will be shared.
 - updates to the storageprovisioner API for watching volume attachments
 - params.VolumeAttachmentId(s) replaced with params.MachineStorageId(s) -- will be reused for filesystems

(Review request: http://reviews.vapour.ws/r/1168/)
49bd93f

@jujubot jujubot merged commit 49bd93f into juju:master Mar 16, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment