Introduce charm.v5-unstable. #1913

Merged
merged 1 commit into from Mar 25, 2015

Conversation

Projects
None yet
3 participants
Member

frankban commented Mar 23, 2015

This mechanical branch updates the charm package to the
v5-unstable version. The legacy charm store code is
adjusted as required.
This is a preparatory work for the migration to the new
charm store API v4.

(Review request: http://reviews.vapour.ws/r/1236/)

Owner

cmars commented Mar 24, 2015

$$merge$$

Contributor

jujubot commented Mar 24, 2015

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

jujubot commented Mar 24, 2015

Build failed: Generating tarball failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/2642

Member

frankban commented Mar 24, 2015

This failure seems due to missing charm.v5-unstable testing dependencies in the dependency file.
Testing dependencies are not included transitively in godeps.
This could be solved by a temporary workaround, e.g.

var _ = charmstore.NewServer

in a testing package.
We are going to import charmstore.v4 for tests anyway.

Owner

cmars commented Mar 24, 2015

@frankban You'll need to add the missing dependencies to Juju's dependencies.tsv in order for this to land. Use godeps -t $(go list $PKG) where $PKG is the transitively included package with the test dependencies (there might be more than one).

Introduce charm.v5-unstable.
This mechanical branch updates the charm package to the
v5-unstable version. The legacy charm store code is
adjusted as required.
This is a preparatory work for the migration to the new
charm store API v4.
Member

frankban commented Mar 25, 2015

$$merge$$

Contributor

jujubot commented Mar 25, 2015

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

jujubot added a commit that referenced this pull request Mar 25, 2015

Merge pull request #1913 from frankban/use-charm-v5-unstable
Introduce charm.v5-unstable.

This mechanical branch updates the charm package to the
v5-unstable version. The legacy charm store code is
adjusted as required.
This is a preparatory work for the migration to the new
charm store API v4.

(Review request: http://reviews.vapour.ws/r/1236/)

@jujubot jujubot merged commit cc52d45 into juju:master Mar 25, 2015

cmars added a commit to cmars/juju that referenced this pull request Apr 2, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment