Merged
Conversation
kian99
force-pushed
the
ssh-server-metrics
branch
from
26cb3ad to
b77dc4a
Compare
Member
|
/build |
kian99
force-pushed
the
ssh-server-metrics
branch
from
b77dc4a to
053912f
Compare
alesstimec
approved these changes
Apr 16, 2025
Contributor
Author
|
/build |
SimoneDutto
reviewed
Apr 16, 2025
Contributor
SimoneDutto
left a comment
SimoneDutto
left a comment
There was a problem hiding this comment.
looks good with a request and a question
| Namespace: metricsNamespace, | ||
| Name: "session_time", | ||
| Help: "The duration a user keeps an SSH session open.", | ||
| Buckets: []float64{1, 10, 60, 300, 600, 3600}, |
Contributor
There was a problem hiding this comment.
a label to differentiate between k8s and machine session would be nice
Contributor
Author
There was a problem hiding this comment.
I think that would be more relevant to the time-to-session one, but I'll add it to both.
Contributor
Author
There was a problem hiding this comment.
I've added it to the timeToSession metric but it's a bit hard to add the model type to this one so I've left it for now.
kian99
force-pushed
the
ssh-server-metrics
branch
from
053912f to
4387a58
Compare
This PR adds metrics for 4 initial measurements: - Connection count - Time to session - Session Duration - Authentication failures
kian99
force-pushed
the
ssh-server-metrics
branch
from
4387a58 to
53b2af1
Compare
Contributor
Author
|
/build |
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds metrics to the SSH server for 4 initial measurements:
The metrics are in Prometheus style format and follows a similar pattern to other workers.
Checklist
Links
Jira card: JUJU-7778