Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Add leadership settings when upgrading. #2127
Conversation
mjs
and others
added some commits
Apr 24, 2015
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
$$try-again$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
added a commit
that referenced
this pull request
Apr 24, 2015
jujubot
merged commit 5f048ed
into
juju:1.23
Apr 24, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ericsnowcurrently commentedApr 24, 2015
(fixes https://bugs.launchpad.net/juju-core/+bug/1447846)
(derived from https://github.com/mjs/juju/tree/1447846-hooks-dont-fire-after-upgrade-1.23)
Charm leadership (added in 1.23) relies on leadership settings stored in the database. Without these settings hooks will not fire. The settings were not being added during upgrades to 1.23. This patch fixes that.
(Review request: http://reviews.vapour.ws/r/1490/)