Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
cmd/juju: assert err value is not nil before inspecting #2321
Conversation
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
added a commit
that referenced
this pull request
May 15, 2015
jujubot
merged commit 87aa2e4
into
juju:master
May 15, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
davecheney commentedMay 13, 2015
Check that the error returned is not nil before trying to inspect it. The code expects the error to not be nil, so fail the test if it is nil (rather than panicing)
Spotted when this code failed my build
http://juju-ci.vapour.ws:8080/job/github-merge-juju/3245/console
(Review request: http://reviews.vapour.ws/r/1682/)