/juju

Fix lp:1454658 TestUseLumberjack fails on windows #2324

Merged
merged 1 commit into from May 14, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@waigani @jujubot
@waigani
Contributor

waigani commented May 13, 2015

Wrap file paths in filepath.FromSlash.

Forward port of a previously reviewed and landed fix: http://reviews.vapour.ws/r/1683/

(Review request: http://reviews.vapour.ws/r/1685/)
@waigani
Fix lp:1454658 TestUseLumberjack fails on windows 
Wrap file paths in filepath.FromSlash.
e1da37c
@waigani
Contributor

waigani commented May 13, 2015

$$fixes-1454658$$
@jujubot
Contributor

jujubot commented May 13, 2015

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju
@jujubot
Contributor

jujubot commented May 13, 2015

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/3252
@waigani
Contributor

waigani commented May 14, 2015

$$fixes-1454658$$
@jujubot
Contributor

jujubot commented May 14, 2015

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

jujubot added a commit that referenced this pull request May 14, 2015

@jujubot
Merge pull request #2324 from waigani/fix-1454658-lumberjack-125 
Fix lp:1454658 TestUseLumberjack fails on windows

Wrap file paths in filepath.FromSlash.

Forward port of a previously reviewed and landed fix: http://reviews.vapour.ws/r/1683/

(Review request: http://reviews.vapour.ws/r/1685/)
45b16dc

@jujubot jujubot merged commit 45b16dc into juju:master May 14, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment