Dynamically discover init system in the cloudinit script. #2359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsnowcurrently
force-pushed
the
fix-1450092-cloudinit-init-system-detection
branch
from
3030a37
to
28e4ad7
Compare
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
ericsnowcurrently
force-pushed
the
fix-1450092-cloudinit-init-system-detection
branch
from
28e4ad7
to
dada170
Compare
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
added a commit
that referenced
this pull request
May 19, 2015
…-init-system-detection Dynamically discover init system in the cloudinit script. (fixes https://bugs.launchpad.net/juju-core/+bug/1450092) Keying off the juju version doesn't work well for local provider. This patch resolves the issue by adding discovery to the cloudinit script. (Review request: http://reviews.vapour.ws/r/1595/)
bz2
added a commit
to bz2/juju
that referenced
this pull request
May 19, 2015
jujubot
added a commit
that referenced
this pull request
May 19, 2015
Revert pr #2359 due to cloud-init breakage This change to doing init system discovery at cloud-init time breaks deployment and windows tests. This reverts commit 01bd454, reversing changes made to 788839e. (Review request: http://reviews.vapour.ws/r/1727/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(fixes https://bugs.launchpad.net/juju-core/+bug/1450092)
Keying off the juju version doesn't work well for local provider. This patch resolves the issue by adding discovery to the cloudinit script.
(Review request: http://reviews.vapour.ws/r/1595/)