Use template generation for starting KVM instances with a MAC address #2493

Merged
merged 17 commits into from Jun 8, 2015

Conversation

Projects
None yet
2 participants

Generate and use an XML template for starting KVM instances when we specify a NIC with a MAC address.

I've manually tested that CreateMachine can successfully start KVM instances with a NIC using the specified MAC address.

(Review request: http://reviews.vapour.ws/r/1860/)

$$merge$$

Contributor

jujubot commented Jun 8, 2015

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

jujubot added a commit that referenced this pull request Jun 8, 2015

Merge pull request #2493 from voidspace/container-macs
Use template generation for starting KVM instances with a MAC address

Generate and use an XML template for starting KVM instances when we specify a NIC with a MAC address.

I've manually tested that CreateMachine can successfully start KVM instances with a NIC using the specified MAC address.

(Review request: http://reviews.vapour.ws/r/1860/)

@jujubot jujubot merged commit f8fc948 into juju:devices-api-maas Jun 8, 2015

dimitern pushed a commit to dimitern/juju that referenced this pull request Nov 9, 2015

@voidspace voidspace deleted the voidspace:container-macs branch Oct 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment