/juju

Generate MAC addresses for container #2565

Merged
merged 14 commits into from Jun 15, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@voidspace @jujubot
@voidspace

voidspace commented Jun 15, 2015

When addressable containers is enabled, the MAC address for templates are generated in advance. This PR also addresses a test issue in lxc-broker_test.go (asserts in the fake API were causing a data race and early test termination). The NetworkInfo member of the return value from lxcbroker.StartInstance is also populated (to ensure the network details are populated in state after provisioning).

(Review request: http://reviews.vapour.ws/r/1935/)
@voidspace

voidspace commented Jun 15, 2015

$$merge$$
@jujubot
Contributor

jujubot commented Jun 15, 2015

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

jujubot added a commit that referenced this pull request Jun 15, 2015

@jujubot
Merge pull request #2565 from voidspace/generate-macs 
Generate MAC addresses for container

When addressable containers is enabled, the MAC address for templates are generated in advance. This PR also addresses a test issue in lxc-broker_test.go (asserts in the fake API were causing a data race and early test termination). The NetworkInfo member of the return value from lxcbroker.StartInstance is also populated (to ensure the network details are populated in state after provisioning).

(Review request: http://reviews.vapour.ws/r/1935/)
ab11052

@jujubot jujubot merged commit ab11052 into juju:devices-api-maas Jun 15, 2015

@voidspace voidspace deleted the voidspace:generate-macs branch Oct 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment