Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
worker: always clear workerInfo.worker before restarting a worker #2668
Conversation
davecheney
added some commits
Jun 29, 2015
davecheney
closed this
Jun 29, 2015
davecheney
deleted the
davecheney:workerinfo
branch
Jun 29, 2015
davecheney
restored the
davecheney:workerinfo
branch
Sep 4, 2015
davecheney
deleted the
davecheney:workerinfo
branch
Apr 13, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
davecheney commentedJun 29, 2015
If a worker is being restarted, make sure that the previous Worker
reference is removed before starting a new one.
Rather than the previous situation where the Kill signal could be delivered
to a previous copy of the worker, this change will cause the runner to
continue to try to issue killAll, which will do nothing as there are no non nil
workerInfo.worker's registered in the worker map, until the new worker reference
is recieved via runner.startedc. At this point the killAll loop will then be able
to issue the Kill command to the correct copy of the worker.
(Review request: http://reviews.vapour.ws/r/2044/)