Add State methods for workload processes. #2674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsnowcurrently
force-pushed
the
proc-state
branch
from
e01507e
to
d1cd6f3
Compare
ericsnowcurrently
force-pushed
the
proc-state
branch
from
d1cd6f3
to
66b6045
Compare
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
added a commit
that referenced
this pull request
Jul 2, 2015
Add State methods for workload processes. The code is split up along several layers: State methods, business logic (ProcessDefinitions/UnitProcesses), high-level persistence (procsPersistence), and low-level/mongo persistence (for now also procsPersistence). I tried to divide along boundaries that I expect we will follow when we introduce a persistence layer abstraction for components. Note that there are a number of open TODO comments. All of them can wait until after we get our demo ready. (Review request: http://reviews.vapour.ws/r/2051/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code is split up along several layers: State methods, business logic (ProcessDefinitions/UnitProcesses), high-level persistence (procsPersistence), and low-level/mongo persistence (for now also procsPersistence). I tried to divide along boundaries that I expect we will follow when we introduce a persistence layer abstraction for components.
Note that there are a number of open TODO comments. All of them can wait until after we get our demo ready.
(Review request: http://reviews.vapour.ws/r/2051/)