Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Add State methods for workload processes. #2674
Conversation
ericsnowcurrently
added some commits
Jun 22, 2015
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
added a commit
that referenced
this pull request
Jul 2, 2015
jujubot
merged commit bd5aee2
into
juju:feature-proc-mgmt
Jul 2, 2015
ericsnowcurrently
deleted the
ericsnowcurrently:proc-state
branch
Jul 2, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ericsnowcurrently commentedJun 29, 2015
The code is split up along several layers: State methods, business logic (ProcessDefinitions/UnitProcesses), high-level persistence (procsPersistence), and low-level/mongo persistence (for now also procsPersistence). I tried to divide along boundaries that I expect we will follow when we introduce a persistence layer abstraction for components.
Note that there are a number of open TODO comments. All of them can wait until after we get our demo ready.
(Review request: http://reviews.vapour.ws/r/2051/)