Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
apiserver: avoid data race in shutdown #2694
Conversation
|
@rogpeppe PTAL |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Does not match ['fixes-1470601'] |
|
$$JFDI$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Does not match ['fixes-1470601'] |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Generating tarball failed |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
davecheney commentedJul 1, 2015
Fixes LP 1465115
Ensure that the listening socket is always the first thing that is closed
when Server.Kill or Stop is issued. This avoids a race where requests in
fly may increase the waitgroup count while the final wg.Wait() defer is in
effect.
(Review request: http://reviews.vapour.ws/r/2072/)