/juju

cmd/juju: Moved most of this package out of package main #2713

Merged
merged 2 commits into from Jul 2, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mattyw @jujubot
@mattyw
Member

mattyw commented Jul 2, 2015

Pretty much all of cmd/juju existed inside the main package. This isn't ideal for testing in downstream projects. The real fix would be to split up the package into smaller chunks (probably one per sub command). This work is already happening in a piecemeal way but while it's happening we still have a large main package.

This is an attempt to make a small step towards fixing the problem. We move pretty much everything out of main - leaving only the bear minimum inside the main package.

(Review request: http://reviews.vapour.ws/r/2091/)

If you've arrived from rb to see a sensible diff here's more advice:

main.go appears totally new in the diff. If you look at the two commits seperately you will see that in the first one it moves and has the package name changed. And in the second commit a new small file is added.
@mattyw
Member

mattyw commented Jul 2, 2015

$$merge$$
@jujubot
Contributor

jujubot commented Jul 2, 2015

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju
@jujubot
Contributor

jujubot commented Jul 2, 2015

Build failed: Generating tarball failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/3881
@mattyw
Member

mattyw commented Jul 2, 2015

$$merge$$
@jujubot
Contributor

jujubot commented Jul 2, 2015

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

jujubot added a commit that referenced this pull request Jul 2, 2015

@jujubot
Merge pull request #2713 from mattyw/juju-cmd-outof-main 
cmd/juju: Moved most of this package out of package main

Pretty much all of cmd/juju existed inside the main package. This isn't ideal for testing in downstream projects. The real fix would be to split up the package into smaller chunks (probably one per sub command). This work is already happening in a piecemeal way but while it's happening we still have a large main package.

This is an attempt to make a small step towards fixing the problem. We move pretty much everything out of main - leaving only the bear minimum inside the main package.

(Review request: http://reviews.vapour.ws/r/2091/)


### If you've arrived from rb to see a sensible diff here's more advice:

main.go appears totally new in the diff. If you look at the two commits seperately you will see that in the first one it moves and has the package name changed. And in the second commit a new small file is added.
5962109

@jujubot jujubot merged commit 5962109 into juju:master Jul 2, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment