Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Enforce use of timeouts for MongoDB connections #2724
Conversation
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
added a commit
that referenced
this pull request
Jul 8, 2015
jujubot
merged commit c928983
into
juju:1.24
Jul 8, 2015
mjs
deleted the
mjs:mongo-timeouts-1.24
branch
Jul 8, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
mjs commentedJul 6, 2015
mongo: use SocketTimeout if not specified in dial options
It doesn't make sense to not set a socket timeout.
Also fixed the incorrect comment for DialOpts.SocketTimeout.
Require that all Juju's connections to MongoDB use a timeout
A possible (but unlikely) fix to LP #1469199 but good to fix anyway. Without this mongo dial attempts could block forever if mongod wasn't there.
(Review request: http://reviews.vapour.ws/r/2102/)