provider/local: avoid spurious errors in Destroy

[axw]

The local provider's Destroy method will sometimes
emit an ugly ERROR log message, but keep on destroying,
if the upstart/systemd service cannot be stopped and
removed. This will often occur because the agent
also stops/removes its service during teardown. To
avoid the ugly error, we attempt the operation twice,
and only log the error on the second attempt.

Fixes https://bugs.launchpad.net/juju-core/+bug/1477263

[howbazaar]

👍

[axw]

$$merge$$

[jujubot]

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

[jujubot]

Build failed: Generating tarball failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/4233

[axw]

"bzr: ERROR:
http://bazaar.launchpad.net/%2Bbranch-id/769359/.bzr/repository/indices/82a0588ac18ed8994f614f8142ee921f.rix
is redirected to https://launchpad.net"
umm.

$$merge$$

On Mon, Aug 10, 2015 at 12:41 PM Juju bot notifications@github.com wrote:

Build failed: Generating tarball failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/4233

—
Reply to this email directly or view it on GitHub
#2888 (comment).

[jujubot]

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju