Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Fix some tests and add relations tests #3168
Conversation
wallyworld
added some commits
Sep 1, 2015
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
added a commit
that referenced
this pull request
Sep 2, 2015
jujubot
merged commit 1cccccd
into
juju:maltese-falcon
Sep 2, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
wallyworld commentedSep 1, 2015
Fix 2 failing tests in relationer_test
Added new unit tests for the previously untested Relations struct.
There's pretty decent coverage, but it's not perfect. Also the relationer_tests are still JujuConnSuite tests. We'll still need to remove all those but this PR is a tspe in the right direction. There's no more skipped tests so we can start thinking about merging to master once we are happy with how things look.
(Review request: http://reviews.vapour.ws/r/2546/)