Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
worker/storageprovisioner: filesystem ops #3177
Conversation
wallyworld
reviewed
Sep 3, 2015
| + volumeTags := make([]names.VolumeTag, 0, len(ctx.incompleteFilesystemParams)) | ||
| + // We only need to query volumes for incomplete filesystems, | ||
| + // and not incomplete filesystem attachments, because a | ||
| + // filesystem attachment cannot exist with a filesystem. |
wallyworld
reviewed
Sep 3, 2015
| + if len(dead) != 0 { | ||
| + // We should not see dead filesystem attachments; | ||
| + // attachments go directly from Dying to removed. | ||
| + logger.Debugf("unexpected dead filesystem attachments: %v", dead) |
|
LGTM. Please test live asap, maybe after unit tests land, or better before, so that any issues can have tests done |
Tested live. |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
added a commit
that referenced
this pull request
Sep 3, 2015
jujubot
merged commit 2c18df5
into
juju:master
Sep 3, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
axw commentedSep 2, 2015
This is a reworking of the filesystem code in
worker/storageprovisioner, same as what was
done recently for volumes. We now maintain a
set of "incomplete parameters" for filesystems
and filesystem attachments, and when they're
completed, schedule operations. These operations
will be attempted and rescheduled on failure,
and filesystem status will be updated according
to the outcome.
Tests have not been added for retrying or
status updates, as this branch is already huge.
I have added a card to follow up on this.