/juju

juju/os: new package #3193

Merged
merged 1 commit into from Sep 3, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@davecheney @jujubot
@davecheney
Contributor

davecheney commented Sep 3, 2015

Introduce new package, juju/os, which is analogous to juju/arch.

The goal of juju/os is to isolate the use of version.Current.OS which is used in relatively few places in the code, and never part of tool bootstrapping.

A subsequent PR will remove the version.Binary.OS field and replace it with a call to os.HostOS(), or derive the value from version.Binary.Series.

(Review request: http://reviews.vapour.ws/r/2571/)
@davecheney
Contributor

davecheney commented Sep 3, 2015

$$merge$$
@jujubot
Contributor

jujubot commented Sep 3, 2015

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju
@jujubot
Contributor

jujubot commented Sep 3, 2015

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/4589
@davecheney
juju/os: new package 
Introduce new package, juju/os, which is analogous to juju/arch.

Replace uses of version.Current.OS with juju/os.HostOS()
fed9c09
@davecheney
Contributor

davecheney commented Sep 3, 2015

$$merge$$
@jujubot
Contributor

jujubot commented Sep 3, 2015

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

jujubot added a commit that referenced this pull request Sep 3, 2015

@jujubot
Merge pull request #3193 from davecheney/introduce-juju-juju-juju-os 
juju/os: new package

Introduce new package, `juju/os`, which is analogous to `juju/arch`.

The goal of `juju/os` is to isolate the use of `version.Current.OS` which is used in relatively few places in the code, and never part of tool bootstrapping.

A subsequent PR will remove the `version.Binary.OS` field and replace it with a call to `os.HostOS()`, or derive the value from `version.Binary.Series`.

(Review request: http://reviews.vapour.ws/r/2571/)
af1504b

@jujubot jujubot merged commit af1504b into juju:master Sep 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment