Migrate to charm.v6-unstable and macaroon-bakery.v1. #3275
Conversation
|
👍 |
1 similar comment
|
👍 |
| gopkg.in/macaroon.v1 git ab3940c6c16510a850e1c2dd628b919f0f3f1464 2015-01-21T11:42:31Z | ||
| gopkg.in/mgo.v2 git 3569c88678d88179dcbd68d02ab081cbca3cd4d0 2015-06-04T15:26:27Z | ||
| gopkg.in/mgo.v2 git f4923a569136442e900b8cf5c1a706c0a8b0883c 2015-08-21T15:31:23Z |
There was a problem hiding this comment.
What are the changes in mgo that are needed for this PR?
|
I'm a little concerned with the newer versions of mgo & tomb, since changes in those dependencies have a lot of potential for introducing side-effects elsewhere in core. |
rogpeppe
force-pushed
the
041-use-charm.v6-unstable-again
branch
from
a5d8071
to
b668aa0
Compare
|
I've reverted the mgo and tomb deps changes. |
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Does not match ['fixes-1494356', 'fixes-1495542', 'fixes-1494913', 'fixes-1495591', 'fixes-1494864', 'fixes-1493887', 'fixes-1494441'] |
rogpeppe
force-pushed
the
041-use-charm.v6-unstable-again
branch
4 times, most recently
from
1360d35
to
277df20
Compare
|
This has now been tested against CI as a feature branch and has been blessed. |
|
LGTM |
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Generating tarball failed |
Conflicts: testing/base_unix.go
rogpeppe
force-pushed
the
041-use-charm.v6-unstable-again
branch
from
277df20
to
973a8ac
Compare
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
Migrate to charm.v6-unstable and macaroon-bakery.v1. This is exactly #3228 re-proposed with dependencies updated so that the tests should pass on windows and so that no dependencies use the apparently problematic encoding package. (Review request: http://reviews.vapour.ws/r/2655/)
This is exactly #3228 re-proposed
with dependencies updated so that the tests should pass on windows
and so that no dependencies use the apparently problematic encoding
package.
(Review request: http://reviews.vapour.ws/r/2655/)