/juju

Renaming ServerTag to be ControllerTag. #3605

Merged
merged 1 commit into from Oct 28, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@howbazaar @jujubot
@howbazaar
Owner

howbazaar commented Oct 28, 2015

This branch renames the ServerTag functions to be ControllerTag.

The main interesting bit is the params structure returned from LoginResposneV1. This still serializes the ControllerTag as 'server-tag' as this shouldn't change. When we make the next version of the login response, we can change the serialization format.

A follow-up branch will handle the serverUUID values.

(Review request: http://reviews.vapour.ws/r/3011/)
@howbazaar
Owner

howbazaar commented Oct 28, 2015

$$merge$$
@jujubot
Contributor

jujubot commented Oct 28, 2015

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

jujubot added a commit that referenced this pull request Oct 28, 2015

@jujubot
Merge pull request #3605 from howbazaar/server-tag-to-controller-tag 
Renaming ServerTag to be ControllerTag.

This branch renames the ServerTag functions to be ControllerTag.

The main interesting bit is the params structure returned from LoginResposneV1. This still serializes the ControllerTag as 'server-tag' as this shouldn't change.  When we make the next version of the login response, we can change the serialization format.

A follow-up branch will handle the serverUUID values.

(Review request: http://reviews.vapour.ws/r/3011/)
85cedb8

@jujubot jujubot merged commit 85cedb8 into juju:master Oct 28, 2015

@howbazaar howbazaar deleted the howbazaar:server-tag-to-controller-tag branch Jan 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment