Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
apiserver/remoterelations: add facade #3779
Conversation
axw
added some commits
Nov 19, 2015
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: bad test |
|
er, test failed. $$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
added a commit
that referenced
this pull request
Nov 23, 2015
jujubot
merged commit 82b9a5f
into
juju:cross-model-relations
Nov 23, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
axw commentedNov 19, 2015
This is part of a new facade that will provide
access to state for an upcoming "remote relations"
worker. The worker will be responsible for
transferring settings between environments involved
in cross-model relations.
The facade is incomplete, but implements a
complex watcher that deserves isolated review.
There are two watchers: one that returns the
IDs of remote services, and one that watches
for any changes to a remote service, or any
of its counterpart relation units.
Tests have been added to featuretests that exercise
the watcher with a real State. Because the client-
side API has not been implemented yet, it is
using the facade methods directly. This will be
changed to call the client methods over the
API server when available, and then later
changed to be exercised via the worker when it
is implemented.
(Review request: http://reviews.vapour.ws/r/3187/)