/juju

network: remove racy InitaliseFromConfig #3785

Merged
merged 1 commit into from Nov 20, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@davecheney @jujubot
@davecheney
Contributor

davecheney commented Nov 20, 2015

Fixes LP 1517744

The package singleton network.globalPreferIPV6 is very racy.

Replace this with a simple atomic variable and a getter and setter.
Also remove the unnecessary PreferIPV6Getter interfaces.

(Review request: http://reviews.vapour.ws/r/3194/)
@davecheney
Contributor

davecheney commented Nov 20, 2015

$$merge$$
@jujubot
Contributor

jujubot commented Nov 20, 2015

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju
@jujubot
Contributor

jujubot commented Nov 20, 2015

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/5520
@davecheney
network: remove racy InitaliseFromConfig 
The package singleton network.globalPreferIPV6 is very racy.

Replace this with a simple atomic variable and a getter and setter.
Also remove the unnecessary PreferIPV6Getter interfaces.
60350f6
@davecheney
Contributor

davecheney commented Nov 20, 2015

$$merge$$
@jujubot
Contributor

jujubot commented Nov 20, 2015

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

jujubot added a commit that referenced this pull request Nov 20, 2015

@jujubot
Merge pull request #3785 from davecheney/fix-global-ipv6-race 
network: remove racy InitaliseFromConfig

Fixes LP 1517744

The package singleton network.globalPreferIPV6 is very racy.

Replace this with a simple atomic variable and a getter and setter.
Also remove the unnecessary PreferIPV6Getter interfaces.

(Review request: http://reviews.vapour.ws/r/3194/)
d1ec2da

@jujubot jujubot merged commit d1ec2da into juju:master Nov 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment