/juju

all: disable any -race test that fails or times out #3806

Merged
merged 2 commits into from Nov 24, 2015
+81 −26

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@davecheney @jujubot
@davecheney
Contributor

davecheney commented Nov 24, 2015

This PR disables any package that fails under the race detector (ie, has a race)
or times out due to internal errors.

(Review request: http://reviews.vapour.ws/r/3216/)

davecheney added some commits Nov 23, 2015

@davecheney
state: disable the package tests in -race mode
9a00daa
@davecheney
all: disable any -race test that fails or times out 
This PR disables any package that fails under the race detector (ie, has a race)
or times out due to internal errors.
6209795
@davecheney
Contributor

davecheney commented Nov 24, 2015

$$merge$$
@jujubot
Contributor

jujubot commented Nov 24, 2015

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

jujubot added a commit that referenced this pull request Nov 24, 2015

@jujubot
Merge pull request #3806 from davecheney/comment-out-more-races 
all: disable any -race test that fails or times out

This PR disables any package that fails under the race detector (ie, has a race)
or times out due to internal errors.

(Review request: http://reviews.vapour.ws/r/3216/)
7652514

@jujubot jujubot merged commit 7652514 into juju:master Nov 24, 2015

@davecheney davecheney deleted the davecheney:comment-out-more-races branch Nov 24, 2015

@dimitern dimitern referenced this pull request Dec 3, 2015

Merged

Fixed lp:1522484 #3890

jujubot added a commit that referenced this pull request Dec 3, 2015

@jujubot
Merge pull request #3890 from dimitern/lp-1522484-master 
Fixed lp:1522484

Fixes the regression caused by #3806 which effectively skipped all
tests in the state package itself (not its subpackages)

Luckily, all tests pass.

(Review request: http://reviews.vapour.ws/r/3309/)
db63077
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment