Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Remove instance.LXD container type #3841
Conversation
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
added a commit
that referenced
this pull request
Nov 27, 2015
jujubot
merged commit da5ec85
into
juju:master
Nov 27, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
axw commentedNov 27, 2015
The worker/provisioner tests fail with Go 1.3+, because they
attempt to provision lxd containers; there is currently no
support for creating lxd containers inside Juju machines.
Seeing as you can't create lxd containers other than through
the lxd provider right now, there's no need for instance.LXD.
Top-level machines don't need to set a container type; they're
not containers as far as Juju is concerned, they're fully-fledged
machines.
When it's possible to add lxd containers inside Juju machines,
instance.LXD should be reintroduced.
Fixes https://bugs.launchpad.net/juju-core/+bug/1520380
(Review request: http://reviews.vapour.ws/r/3260/)