/juju

fix api/metricsadder & apiserver/environment test compilation with ne… #3961

Merged
merged 1 commit into from Dec 15, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mwhudson @anastasiamac @jujubot
@mwhudson
Contributor

mwhudson commented Dec 14, 2015

…w gccgo

gccgo (in xenial at least) is stricter than gc when it comes to a certain
class of declared but not used variable, see:

https://github.com/golang/go/issues/6415
https://github.com/golang/go/issues/3059
@mwhudson
fix api/metricsadder & apiserver/environment test compilation with ne… 
…w gccgo

gccgo (in xenial at least) is stricter than gc when it comes to a certain
class of declared but not used variable, see:

    golang/go#6415
    golang/go#3059
cff2cb9
@anastasiamac
Member

anastasiamac commented Dec 15, 2015

LGTM
@mwhudson
Contributor

mwhudson commented Dec 15, 2015

$$merge$$
@anastasiamac
Member

anastasiamac commented Dec 15, 2015

$$merge$$
@jujubot
Contributor

jujubot commented Dec 15, 2015

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

jujubot added a commit that referenced this pull request Dec 15, 2015

@jujubot
Merge pull request #3961 from mwhudson/metricsadder-vars 
fix api/metricsadder & apiserver/environment test compilation with ne…

…w gccgo

gccgo (in xenial at least) is stricter than gc when it comes to a certain
class of declared but not used variable, see:

    golang/go#6415
    golang/go#3059
f81ca41

@jujubot jujubot merged commit f81ca41 into juju:master Dec 15, 2015

@mwhudson mwhudson deleted the mwhudson:metricsadder-vars branch Dec 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment