Read only facade check #4003
Merged
Read only facade check #4003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // At this stage, any facade that is part of the restricted root | ||
| // (those that are accessable outside of environments) are OK | ||
| // because the user would have access to those facades if the went | ||
| // through the controller API endpoint rather than an environme |
|
LGTM! |
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
added a commit
that referenced
this pull request
Feb 5, 2016
Read only facade check When an environment user has only read access to the environment, the apiserver adds an extra method lookup filter. The read only check has been kept quite separate from the user lookup as the read only code will also be used for model migrations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an environment user has only read access to the environment, the apiserver adds an extra method lookup filter.
The read only check has been kept quite separate from the user lookup as the read only code will also be used for model migrations.