Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Minimal working implementation on network-get hook tool on MAAS #4029
Conversation
added some commits
Jan 2, 2016
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
added a commit
that referenced
this pull request
Jan 5, 2016
jujubot
merged commit f21d00a
into
juju:maas-spaces
Jan 5, 2016
dimitern
deleted the
dimitern:maas-spaces-network-get-min
branch
Jan 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
dimitern commentedJan 4, 2016
Tested with a couple of simple charms based on the ubuntu charm, but with
a few relations, which can be bound to spaces and later the addresses we
get from network-get within each relation are logged.
Key changes:
each IP is bound to (according to the links of each interface).
which solves the problems with non-deterministic address picking and sorting.
As a fallback, the old approach with scopes + sorting is used.
with all bindings from all services which have units assigned to the machine we're
about to provision. This also takes full advantage of the "interfaces=" argument
in MAAS (acquireNode) for bindings.
Next step should be to do the multi-NIC containers in a simplified way.
(Review request: http://reviews.vapour.ws/r/3448/)