Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Backport fix for LP 1533792 to 1.25 branch #4109
Conversation
|
$$JDFI$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Does not match ['fixes-1533849', 'fixes-1533751'] |
|
$$JFDI$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Does not match ['fixes-1533849', 'fixes-1533751'] |
|
$$fixes-1533849$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
added a commit
that referenced
this pull request
Jan 14, 2016
jujubot
merged commit 0377d2a
into
juju:1.25
Jan 14, 2016
davecheney
deleted the
davecheney:backport-1533792-1.25
branch
Jan 14, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
davecheney commentedJan 14, 2016
Fixes LP 1533792
gccgo-4.9 as shipped in Trusty has a number of issues when interfaces
and reflection are combined. In an ideal world these bugs would not
happen, but they do, so the most expedient course of action is to
work around them in our code.
This change replaces the reflection driven construction of a state.SubnetInfo
structure with a more straight forward method which permutes the string
fields known to the structure today. This isn't as future proof as the
previous method, but avoiding the faustian combinaton of interfaces and
reflection should make this code more reliable on buggy compilers.
(Review request: http://reviews.vapour.ws/r/3531/)