cloud: restructure cloud credentials types #4162

Merged
merged 3 commits into from Jan 21, 2016

Conversation

Projects
None yet
2 participants
Member

axw commented Jan 21, 2016

It does not scale well to have concrete types
for each provider's auth-type, so Credential
has been made into a struct which contains
the raw attributes, and the auth-type constant.

Each provider will later be extended with
methods for returning the credential schemas
they support, and for automatically detecting
credentials from the environment.

An initial implementation of list-credentials
has been added to demonstrate the use of the
ParseCredentials function.

Parsing credentials no longer validates the
attributes. This enables us to lazily validate
only the credentials selected during bootstrap.

(Review request: http://reviews.vapour.ws/r/3587/)

axw added some commits Jan 21, 2016

cloud: restructure cloud credentials types
It does not scale well to have concrete types
for each provider's auth-type, so Credential
has been made into a struct which contains
the raw attributes, and the auth-type constant.

Each provider will later be extended with
methods for returning the credential schemas
they support, and for automatically detecting
credentials from the environment.

An initial implementation of list-credentials
has been added to demonstrate the use of the
ParseCredentials function.

Parsing credentials no longer validates the
attributes. This enables us to lazily validate
only the credentials selected during bootstrap.
Member

axw commented Jan 21, 2016

$$merge$$

Contributor

jujubot commented Jan 21, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

jujubot added a commit that referenced this pull request Jan 21, 2016

Merge pull request #4162 from axw/cloud-credentials-refactor
cloud: restructure cloud credentials types

It does not scale well to have concrete types
for each provider's auth-type, so Credential
has been made into a struct which contains
the raw attributes, and the auth-type constant.

Each provider will later be extended with
methods for returning the credential schemas
they support, and for automatically detecting
credentials from the environment.

An initial implementation of list-credentials
has been added to demonstrate the use of the
ParseCredentials function.

Parsing credentials no longer validates the
attributes. This enables us to lazily validate
only the credentials selected during bootstrap.

(Review request: http://reviews.vapour.ws/r/3587/)

@jujubot jujubot merged commit 1167ea6 into juju:cloud-credentials Jan 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment