/juju

WIP: Added support and tests for "controller space" #4255

Closed
wants to merge 19 commits into
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@dimitern
@dimitern
Contributor

dimitern commented Feb 1, 2016

For early review, some tests still need fixing, but this PR is necessary
to make it possible to merge maas-spaces into master for alpha2.

(Review request: http://reviews.vapour.ws/r/3693/)

Dimiter Naydenov added some commits Jan 29, 2016

environs/config: Added controller-space setting
27f2d6f
environs/bootstrap: Controller space validated when given
925e20a
cmd/juju: bootstrap uses --controller-space if given
602617f
provider/maas: Refactored interfaces handling; added PXE NIC discovery
47edb43
environs/config: Extra tests for controller-space to verify MAAS beha… 
…vior
2541525
Provider-independent controller space handling and better error tracing
68f4fc3
provider/maas: Controller space inferred if not specified, validated … 
…,and set
be85ede
uniter: Don't rely on network.DefaultSpace being there
b692528
network: Use specified controller space for address/hostport selectio… 
…n; changes are now also fully tested
67b6632
worker/peergrouper: Controller space used for peer selection; needs m… 
…ore tests for non-empty controller space, for now that case is only live tested on MAAS
c47f216
agent: BootstrapMachineConfig includes ControllerSpaceName, used when… 
… set, and saved in AgentEnvironment
2747640
mongo, state: Controller space name used for peer and API addresses s… 
…election
8e82ce1
cmd/jujud, provider/common: Pass controller space at bootstrap to the… 
… agent config and bootstrap params
247a7af
API endpoints everywhere now selected using controller space, if set
c5778c7
state: Use controller space (when set) for unspecified service endpoi… 
…nt bindings; a few tests still need fixing
0ca3e48
Disabled a few unit tests temporarily to try and pass the branch thro… 
…ugh CI
7374dd9
Disabled a few more unit tests temporarily to try and pass the branch… 
… through CI
18d90bd
state: Refactored and simplified endpoint bindings, made them optiona… 
…l; some tests need fixing later
b95fd64
provider/maas: More logging and possible fix for the CI issues with t… 
…rusty on 1.9
b6df0e4
@dimitern
Contributor

dimitern commented Feb 3, 2016

Superseded by the changes in:
https://github.com/juju/juju/compare/maas-spaces...dimitern:maas-spaces-controller-space-after-master-merge?expand=1

@dimitern dimitern closed this Feb 3, 2016

@dimitern dimitern deleted the dimitern:maas-spaces-controller-space-config branch Feb 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment