Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
new package: cmd/pprof #4259
Conversation
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Does not match ['fixes-1538241'] |
|
I have evaluated the risk of landing this on a blocked master, and I believe that this work has benefits that well outweigh any risk, and the risk and impact of this change is very small. I'll take that risk. JFDI |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Generating tarball failed |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
davecheney commentedFeb 2, 2016
Updates LP #1519473
This PR adds a new package, github.com/juju/juju/cmd/pprof, a fork of
net/http/pprof. The fork is necessary because importing the latter package
automatically registers debug handlers with the default server mux, which
juju does not go to lengths to protect, and exposing this data over http
will set off an explosion of security hand wringing.
Instead, the package provides a way to export the same handlers over a
unix socket owned by the user starting the process. To access the debug
statistics, which are read only, you must have physical access to the host.
These statistics are only enabled in cmd/jujud when it is acting as jujud,
a machine or unit agent.
(Review request: http://reviews.vapour.ws/r/3697/)