new package: cmd/pprof #4259

Merged
merged 1 commit into from Feb 2, 2016

Conversation

Projects
None yet
3 participants
Contributor

davecheney commented Feb 2, 2016

Updates LP #1519473

This PR adds a new package, github.com/juju/juju/cmd/pprof, a fork of
net/http/pprof. The fork is necessary because importing the latter package
automatically registers debug handlers with the default server mux, which
juju does not go to lengths to protect, and exposing this data over http
will set off an explosion of security hand wringing.

Instead, the package provides a way to export the same handlers over a
unix socket owned by the user starting the process. To access the debug
statistics, which are read only, you must have physical access to the host.

These statistics are only enabled in cmd/jujud when it is acting as jujud,
a machine or unit agent.

(Review request: http://reviews.vapour.ws/r/3697/)

Contributor

davecheney commented Feb 2, 2016

$$merge$$

Contributor

jujubot commented Feb 2, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

jujubot commented Feb 2, 2016

Build failed: Does not match ['fixes-1538241']
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/6157

Owner

howbazaar commented Feb 2, 2016

I have evaluated the risk of landing this on a blocked master, and I believe that this work has benefits that well outweigh any risk, and the risk and impact of this change is very small.

I'll take that risk.

JFDI

Contributor

davecheney commented Feb 2, 2016

$$merge$$

Contributor

jujubot commented Feb 2, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

jujubot commented Feb 2, 2016

Build failed: Generating tarball failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/6158

new package: cmd/pprof
Updates LP #1519473

This PR adds a new package, github.com/juju/juju/cmd/pprof, a fork of
net/http/pprof. The fork is necessary because importing the latter package
automatically registers debug handlers with the default server mux, which
juju does not go to lengths to protect, and exposing this data over http
will set of an explosion of security hand wringing.

Instead, the package provides a way to export the same handlers over a
unix socket owned by the user starting the process. To access the debug
statistics, which are read only, you must have physical access to the host.

These statistics are only enabled in cmd/jujud when it is acting as jujud,
a machine or unit agent.
Contributor

davecheney commented Feb 2, 2016

$$merge$$

Contributor

jujubot commented Feb 2, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

jujubot added a commit that referenced this pull request Feb 2, 2016

Merge pull request #4259 from davecheney/pprof
new package: cmd/pprof

Updates LP #1519473

This PR adds a new package, github.com/juju/juju/cmd/pprof, a fork of
net/http/pprof. The fork is necessary because importing the latter package
automatically registers debug handlers with the default server mux, which
juju does not go to lengths to protect, and exposing this data over http
will set off an explosion of security hand wringing.

Instead, the package provides a way to export the same handlers over a
unix socket owned by the user starting the process. To access the debug
statistics, which are read only, you must have physical access to the host.

These statistics are only enabled in cmd/jujud when it is acting as jujud,
a machine or unit agent.

(Review request: http://reviews.vapour.ws/r/3697/)

@jujubot jujubot merged commit 0c80861 into juju:master Feb 2, 2016

@davecheney davecheney referenced this pull request Feb 2, 2016

Merged

new package: cmd/pprof #4262

dimitern pushed a commit to dimitern/juju that referenced this pull request Feb 2, 2016

jujubot added a commit that referenced this pull request Feb 3, 2016

Merge pull request #4262 from davecheney/pprof-backport
new package: cmd/pprof

Backport of #4259 to 1.25

Updates LP #1519473

This PR adds a new package, github.com/juju/juju/cmd/pprof, a fork of
net/http/pprof. The fork is necessary because importing the latter package
automatically registers debug handlers with the default server mux, which
juju does not go to lengths to protect, and exposing this data over http
will set of an explosion of security hand wringing.

Instead, the package provides a way to export the same handlers over a
unix socket owned by the user starting the process. To access the debug
statistics, which are read only, you must have physical access to the host.

These statistics are only enabled in cmd/jujud when it is acting as jujud,
a machine or unit agent.

(Review request: http://reviews.vapour.ws/r/3700/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment