/juju

Pass new state to apiserver worker each time it is started #4266

Merged
merged 1 commit into from Feb 2, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@wallyworld @cherylj @jujubot
@wallyworld
Owner

wallyworld commented Feb 2, 2016

Fixes: https://bugs.launchpad.net/juju-core/+bug/1539656

Each time apiserverworker is started, we need a fresh copy of state.
I experimented with aborting/resetting the lease manager to avoid having to create a new copy of state but it got messy. This is the simplest approach. We can revisit once William's todo with setting up the lease manager (in the HackLeadership code) is done.

(Review request: http://reviews.vapour.ws/r/3704/)
@cherylj

cherylj commented Feb 2, 2016

$$JFDI$$
@jujubot
Contributor

jujubot commented Feb 2, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

jujubot added a commit that referenced this pull request Feb 2, 2016

@jujubot
Merge pull request #4266 from wallyworld/lease-manager-restart 
Pass new state to apiserver worker each time it is started

Fixes: https://bugs.launchpad.net/juju-core/+bug/1539656

Each time apiserverworker is started, we need a fresh copy of state.
I experimented with aborting/resetting the lease manager to avoid having to create a new copy of state but it got messy. This is the simplest approach. We can revisit once William's todo with setting up the lease manager (in the HackLeadership code) is done.

(Review request: http://reviews.vapour.ws/r/3704/)
462a3d6

@jujubot jujubot merged commit 462a3d6 into juju:master Feb 2, 2016

wallyworld added a commit to wallyworld/juju that referenced this pull request Feb 2, 2016

@jujubot @wallyworld
Merge pull request #4266 from wallyworld/lease-manager-restart 
Pass new state to apiserver worker each time it is started

Fixes: https://bugs.launchpad.net/juju-core/+bug/1539656

Each time apiserverworker is started, we need a fresh copy of state.
I experimented with aborting/resetting the lease manager to avoid having to create a new copy of state but it got messy. This is the simplest approach. We can revisit once William's todo with setting up the lease manager (in the HackLeadership code) is done.

(Review request: http://reviews.vapour.ws/r/3704/)
e0fc2ca

jujubot added a commit that referenced this pull request Feb 2, 2016

@jujubot
Merge pull request #4271 from wallyworld/lease-manager-restart-1.25 
Merge pull request #4266 from wallyworld/lease-manager-restart

Pass new state to apiserver worker each time it is started

Fixes: https://bugs.launchpad.net/juju-core/+bug/1539656

Each time apiserverworker is started, we need a fresh copy of state.
I experimented with aborting/resetting the lease manager to avoid having to create a new copy of state but it got messy. This is the simplest approach. We can revisit once William's todo with setting up the lease manager (in the HackLeadership code) is done.

(Review request: http://reviews.vapour.ws/r/3704/)

(Review request: http://reviews.vapour.ws/r/3709/)
9f5ca7e

dimitern pushed a commit to dimitern/juju that referenced this pull request Feb 4, 2016

@jujubot
Merge pull request #4266 from wallyworld/lease-manager-restart 
Pass new state to apiserver worker each time it is started

Fixes: https://bugs.launchpad.net/juju-core/+bug/1539656

Each time apiserverworker is started, we need a fresh copy of state.
I experimented with aborting/resetting the lease manager to avoid having to create a new copy of state but it got messy. This is the simplest approach. We can revisit once William's todo with setting up the lease manager (in the HackLeadership code) is done.

(Review request: http://reviews.vapour.ws/r/3704/)
1da991c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment