/juju

cmd/pprof: address review followups #4275

Merged
merged 1 commit into from Feb 3, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@davecheney @jujubot @howbazaar
@davecheney
Contributor

davecheney commented Feb 3, 2016

Address review comments raised during the 1.25 backport.

  • Added package commentary identifying the changes made in this fork.
  • Added tests of the pprof server and Start/stop logic.

(Review request: http://reviews.vapour.ws/r/3713/)
@davecheney
cmd/pprof: address review followups 
Address review comments raised during the 1.25 backport.
cbd014d
@davecheney
Contributor

davecheney commented Feb 3, 2016

$$JDFI$$
@jujubot
Contributor

jujubot commented Feb 3, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju
@jujubot
Contributor

jujubot commented Feb 3, 2016

Build failed: Does not match ['fixes-1538241']
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/6180
@howbazaar
Owner

howbazaar commented Feb 3, 2016

$$JFDI$$ You need _ not *
@jujubot
Contributor

jujubot commented Feb 3, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju
@jujubot
Contributor

jujubot commented Feb 3, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/6183
@davecheney
Contributor

davecheney commented Feb 3, 2016

mongo blew up causing an unrelated test failure, trying again

$$JFDI$$
@jujubot
Contributor

jujubot commented Feb 3, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

jujubot added a commit that referenced this pull request Feb 3, 2016

@jujubot
Merge pull request #4275 from davecheney/pprof-followup 
cmd/pprof: address review followups

Address review comments raised during the 1.25 backport.

- Added package commentary identifying the changes made in this fork.
- Added tests of the pprof server and Start/stop logic.

(Review request: http://reviews.vapour.ws/r/3713/)
d8d336c

@jujubot jujubot merged commit d8d336c into juju:master Feb 3, 2016

dimitern pushed a commit to dimitern/juju that referenced this pull request Feb 3, 2016

@jujubot
Merge pull request #4275 from davecheney/pprof-followup 
cmd/pprof: address review followups

Address review comments raised during the 1.25 backport.

- Added package commentary identifying the changes made in this fork.
- Added tests of the pprof server and Start/stop logic.

(Review request: http://reviews.vapour.ws/r/3713/)
577b503

dimitern pushed a commit to dimitern/juju that referenced this pull request Feb 3, 2016

@jujubot
Merge pull request #4275 from davecheney/pprof-followup 
cmd/pprof: address review followups

Address review comments raised during the 1.25 backport.

- Added package commentary identifying the changes made in this fork.
- Added tests of the pprof server and Start/stop logic.

(Review request: http://reviews.vapour.ws/r/3713/)
b9f4246
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment