/juju

Add helpers for testing PostUpgradeManifold based manifolds #4277

Merged
merged 2 commits into from Feb 3, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mjs @jujubot
@mjs
Contributor

mjs commented Feb 3, 2016

worker/testing: Add helpers for testing PostUpgradeManifold based manifolds

These helpers simplify writing unit tests for manifolds based on PostUpgradeManifold.

worker/proxyupdater: Add unit tests for proxyupdater manifold

Tests like this are now easier to write thanks to the RunPostUpgradeManifold helper.

(Review request: http://reviews.vapour.ws/r/3715/)

mjs added some commits Feb 3, 2016

@mjs
worker/testing: Add helpers for testing PostUpgradeManifold based man… 
…ifolds

These helpers simplify writing unit tests for manifolds based on
PostUpgradeManifold.
e035164
@mjs
worker/proxyupdater: Add unit tests for proxyupdater manifold 
Tests like this are now easier to write thanks to the
RunPostUpgradeManifold helper.
68baa14
@mjs
Contributor

mjs commented Feb 3, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Feb 3, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju
@jujubot
Contributor

jujubot commented Feb 3, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/6187
@mjs
Contributor

mjs commented Feb 3, 2016

$$bad-record-mac$$
@jujubot
Contributor

jujubot commented Feb 3, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

jujubot added a commit that referenced this pull request Feb 3, 2016

@jujubot
Merge pull request #4277 from mjs/postupgrademanifold-test-helper 
Add helpers for testing PostUpgradeManifold based manifolds

worker/testing: Add helpers for testing PostUpgradeManifold based manifolds

These helpers simplify writing unit tests for manifolds based on PostUpgradeManifold.

---

worker/proxyupdater: Add unit tests for proxyupdater manifold

Tests like this are now easier to write thanks to the RunPostUpgradeManifold helper.



(Review request: http://reviews.vapour.ws/r/3715/)
2c23dc6

@jujubot jujubot merged commit 2c23dc6 into juju:MADE-workers Feb 3, 2016

@mjs mjs deleted the mjs:postupgrademanifold-test-helper branch Feb 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment