/juju

apiserver: remove testing helper method #4335

Merged
merged 1 commit into from Feb 8, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@davecheney @jujubot
@davecheney
Contributor

davecheney commented Feb 8, 2016

  • apiserver.Server.Addr was only used in testing contexts, removed from
    the public API.
  • Rejig the initialisation to log the "server is listening" message closer
    to the point where the server starts listening.

(Review request: http://reviews.vapour.ws/r/3779/)
@davecheney
apiserver: remove testing helper method 
apiserver.Server.Addr was only used in testing contexts, removed from
the public API.
Rejig the initalisation to log the "server is listening" message closer
to the point where the server starts listening.
dd25b33
@davecheney
Contributor

davecheney commented Feb 8, 2016

$$JFDI$$
@jujubot
Contributor

jujubot commented Feb 8, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

jujubot added a commit that referenced this pull request Feb 8, 2016

@jujubot
Merge pull request #4335 from davecheney/apiserver-cleanup 
apiserver: remove testing helper method

- apiserver.Server.Addr was only used in testing contexts, removed from
the public API.
- Rejig the initialisation to log the "server is listening" message closer
to the point where the server starts listening.

(Review request: http://reviews.vapour.ws/r/3779/)
cbb4656

@jujubot jujubot merged commit cbb4656 into juju:master Feb 8, 2016

@davecheney davecheney deleted the davecheney:apiserver-cleanup branch Feb 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment