Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
cloudconfig/sshinit: don't send commands to stdin #4349
Conversation
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Does not match ['fixes-1538241', 'fixes-1544796'] |
|
$$JFDI$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Generating tarball failed |
|
$$JFDI$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
added a commit
that referenced
this pull request
Feb 22, 2016
jujubot
merged commit bab6369
into
juju:master
Feb 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
axw commentedFeb 9, 2016
Turns out that bash reads byte-at-a-time when reading
commands from stdin. This is likely so it can avoid
buffering more than a command's worth of input.
Anyway, we send huge scripts to bash at bootstrap
time, particularly when uploading tools. With this
change, we avoid sending the script to bash directly,
and instead write it to the remote disk and execute
it from there.
Fixes https://bugs.launchpad.net/juju-core/+bug/1543388
(Review request: http://reviews.vapour.ws/r/3793/)