/juju

rcp: simplify serverError type #4357

Merged
merged 1 commit into from Feb 10, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@davecheney @jujubot
@davecheney
Contributor

davecheney commented Feb 9, 2016

serverError was over compliated. It did not need to inherit from
requestError, and the way it did was overengineered. serverError just
needs to extend the error interface to match the ErrorCoder interface,
and as serverError only knows one status code, we can hard code that as
well.

(Review request: http://reviews.vapour.ws/r/3802/)
@davecheney
rcp: simplify serverError type 
serverError was over compliated. It did not need to inherit from
requestError, and the way it did was overengineered. serverError just
needs to extend the error interface to match the ErrorCoder interface,
and as serverError only knows one status code, we can hard code that as
well.
863b52d
@davecheney
Contributor

davecheney commented Feb 10, 2016

$$JFDI$$
@jujubot
Contributor

jujubot commented Feb 10, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

jujubot added a commit that referenced this pull request Feb 10, 2016

@jujubot
Merge pull request #4357 from davecheney/rpc-simplify-server-error 
rcp: simplify serverError type

serverError was over compliated. It did not need to inherit from
requestError, and the way it did was overengineered. serverError just
needs to extend the error interface to match the ErrorCoder interface,
and as serverError only knows one status code, we can hard code that as
well.

(Review request: http://reviews.vapour.ws/r/3802/)
2c11d4b

@jujubot jujubot merged commit 2c11d4b into juju:master Feb 10, 2016

@davecheney davecheney deleted the davecheney:rpc-simplify-server-error branch Feb 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment