api/block: driveby cleanups #4401

Merged
merged 2 commits into from Mar 7, 2016

Conversation

Projects
None yet
3 participants
Contributor

davecheney commented Feb 12, 2016

Multi line logging, seriously ??

api/block/client.go
- return result.Error
- }
- return nil
+ return errors.Trace(result.Error)
@mjs

mjs Feb 26, 2016

Contributor

The original code was weird here!

Contributor

mjs commented Feb 26, 2016

LGTM

Contributor

davecheney commented Feb 26, 2016

$$merge$$

Contributor

jujubot commented Feb 26, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

jujubot commented Feb 26, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/6563

Contributor

davecheney commented Feb 28, 2016

$$merge$$

Contributor

jujubot commented Feb 28, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

jujubot commented Feb 28, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/6586

api/block: driveby cleanups
Multi line logging, seriously ??
Contributor

davecheney commented Mar 6, 2016

$$JFDI$$

Contributor

jujubot commented Mar 6, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

jujubot commented Mar 6, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/6682

Contributor

davecheney commented Mar 6, 2016

$$JFDI$$

Contributor

jujubot commented Mar 6, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

jujubot commented Mar 6, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/6683

Contributor

davecheney commented Mar 6, 2016

$$JFDI$$

Contributor

jujubot commented Mar 6, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

jujubot added a commit that referenced this pull request Mar 7, 2016

Merge pull request #4401 from davecheney/api-block-driveby
api/block: driveby cleanups

Multi line logging, seriously ??

@jujubot jujubot merged commit 182ecb1 into juju:master Mar 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment